Java: creating objects in an array of objects

[Dingod]

Hey guys,

Im coding doing my bank program and have progressed alot since last time I posted here but have again encoutered some problems. This time its down the bottem of the BankManager class where Im trying to create objects of the Account class and store them in the Accounts array created here... if someone can guide me on how to do that it would be much appreciated.

Also with the statement :

while (// accountType.equals("S") || accountType.equals("C"));

how do I make that so that its tests to see if the accountType does not equal "S" or "C"??



BankManager Class

// 

import java.io.*;
import java.util.*;


class 	BankManager extends Keyboard
 {
		Account [] account = new Account [50];
		String menuChoice, roomNum, capacity, roomType;
		boolean decision = true;
		String accIdString;
		int accId;
		String accountType;
	
		// put whatever fucking variables are meant to be in here
		
public void exe()
{
	do 
	{
		showMenu();
			
		System.out.print("/n>>>>> Please select : ");
		String menuChoiceInput;
		
		menuChoiceInput = readLine().toUpperCase();
		char menuChoice ;
		menuChoice	 = menuChoiceInput.charAt(0);
			
		switch (menuChoice)
		{
				case 'C':
			
			//	createAccount()
			
				case 'R':
			
				//Records a transaction
			
				case 'D':
			
				//Displays information of an account
			
				case 'A':
			
				//Display information of all accounts
			
				case 'Q': //quits the program
					decision = false;
					break;
				
		 		default:
		 			System.out.println ("/n ????? Incorrect command");
		 }
		}
		while (decision);
}


	
		
		public void displayAccInf()
		{
			
		}
		
		public void displayAccInfALL()
		{
			
			
		}
		
		
		public int findAcc(int accId)
		{
			int currentValue;
			int indexAccount=-1;
			for (int i=0; i<account.length; i++)
			{
							
				if (account[i].accId == accId)
					indexAccount=i;
			}		
			return indexAccount;
		
		}
		
		
	private void showMenu()
		{
			System.out.println ("/n ***************************");
			System.out.println ("C --- Create a new account");
			System.out.println ("R --- Record a transaction");
			System.out.println ("D --- Display information of an account");
			System.out.println ("A --- Display information of all accounts");
			System.out.println ("Q --- Quit the program");
		}
	
	
			
	private void createAccount()
	{
		System.out.print("/n>>>>> Please enter Account ID : ");
		accIdString=readLine();
		accId = Integer.valueOf(accIdString).intValue();
		findAcc(accId);
		
		
	
		if (accId == -1)
			System.out.println ("/n????? The room number has been used.");
			
		else{
			do{
				System.out.print ("/n>>>>> Please enter account type: ");
				AccountType=readLine().toUpperCase();}
		while (accountType.equals("S") || accountType.equals("C"));

		if (roomType.equals("C"))
	//		how do I create a new account object in the Account array here?
		
	}
}
}

Account Class:

public class Account
{
	int accId;
	char accType;
	int numTransactions=0;
	double balance = 100;
	Transaction [] transaction = new Transaction [50];
	
	public void Account (int accId, char accType)
	{
		this.accId = accId;
		
		this.accType = accType;
	}

		
}

[xsive]

You need to check the number of created items in your array and then add the new object at the next position. You can achieve this by:

account[account.size()-1] = new Account();

This will create an account in the next available array position. If you solution involves deleting Accounts, you will need to pack the array each time an Account is removed.

Also with the statement :

while (// accountType.equals("S") || accountType.equals("C"));

how do I make that so that its tests to see if the accountType does not equal "S" or "C"??

Try

while(! (accountType.equals("C") || accountType.equals("S"))

the ! represents NOT.

[xsive]

A few other tips:

..
if (account[i].accId == accId)
..

Preceed your variable declarations in the Account class by the keyword "private". This will ensure the variables are not directly accessible by foreign classes.
No other class should have any business directly modifying or calling any other class' variables. Maintain encapsulation at all times. Its not only good OO design but it makes your code easier more legible and maintainable.
Create get and set accessor methods for each private variable to allow external modification (where appropriate).
These methods should be public.

Although its sometimes necessary to break encapsulation, 99% of the time you can avoid it by using good OO design principles.

[YarrKen]

Also, instead of the array, look at using Vectors - dont have to worry about sizes then, it will dynamically grow and shrink

[Bangers]

And your Constructor to Account class is wrong, you don't give it a return type. Just "public Account()"

[nida]

Originally posted by Bangers
And your Constructor to Account class is wrong, you don't give it a return type. Just "public Account()"

there is no return type. the information given in the brackets there are parameters necessary to create an account object. the account class is perfectly fine as far as i can see.

[PoyZ]

public void Account (int accId, char accType)

Bangers meant that the void keyword is not required.

Constructors don't need a return type.

[nida]

Originally posted by PoyZ
Bangers meant that the void keyword is not required.

Constructors don't need a return type.

aah, *pulls away in shame*

missed that...

[Dingod]

lol I just had a thought that if someone else is doing the same subject as me they could come here and steal my code

hahaha no where near finished anyway and its due 2morrow...

/me gets back to work

[nida]

where are you studying in adelaide?

[Dingod]

Originally posted by nida
where are you studying in adelaide?

Mawson Lakes and Magill, Uni Sa

[nida]

what program and year?

[Dingod]

Originally posted by nida
what program and year?

MBIC 2nd year.... why? plz dont stalk me

[Dingod]

hrmm i've encountered yet another problem *sigh* some help please asap as its due in 2morrow but im probably doing to stay up 2night night until its done.

My problem is with this line

account[accountSize()] = new Account(1, 'c');

I've only got the 1 and 'c' in there for testing purposes... this is the error I get:

symbol : constructor Account (int,char)
location: class Account
account[accountSize()] = new Account(1, 'c');

it seems right to me.. any tips/help/pointers will be much appreciated.

the account class is at the bottom

Bank Manager Class:

	private void createAccount()
	{
		System.out.print("/n>>>>> Please enter Account ID : ");
		accIdString=readLine();
		accId = Integer.valueOf(accIdString).intValue();
		findAcc(accId);
		
		
	
		if (accId == -1)
		{
			
				System.out.print ("/n>>>>> Please enter account type: ");
				accountType=readLine().toUpperCase();}
				accountTypeChar = accountType.charAt(0);
		
		if ((accountType.equals("S") || accountType.equals("C")))
		{
			account[accountSize()] = new Account(1, 'c');
			execute();
		}
		else
		{
			execute();
		}
	}

Account Class:

public class Account
{
	int accId;
	char accType;
	int numTransactions=0;
	double balance = 100;
	Transaction [] transaction = new Transaction [50];
	
	public void Account (int accId, char accType)
	{
		this.accId = accId;
		
		this.accType = accType;
	}


		
}

[Sprinkleh]

This is what others have already said but you havent done it so..
in account class remove the void word in the constructor.. they dont return anything.

and for this line

account[accountSize()] = new Account(1, 'c');

make it

account[account.Size()-1] = new Account(1, 'c');