Need help with PHP coding.

[dicey]

Hola!

I need help with some PHP coding. I need to see if this is correct. Because it doesn't seem to be correct to me.

I have this in a sep script. Known as bs.php

PHP Code:

<?php
if ($page=='about') include('about.php');
if ($page=='photoalbum') include('album.php');
if ($page=='links') include('links.php');
if ($page=='about-brandon') include('brandon.php');
if (file_exists($show)){
@include("$show");
}else{
@include("error404.php");
}
?>

http://www.xis.com.au/~dicey/ <=- this is the site.

What's the problem is. That I'm trying to set a 404 error page. Like this page:

http://www.xis.com.au/~dicey/bs.php?page=drinking

But... When Someone clicks on a link that works. For Example:

http://www.xis.com.au/~dicey/bs.php?page=about

Somehow something is inlcuding the error404.php into any page that works!

It's pissing me off! Please tell me what to do!

Thank you.

[mpot]

I know SFA about PHP, but do have experience with a number of other server-side scripting languages....so I'll have a go...

I don't believe you can do conditional includes.

Instead, always @include error404.php on every page.
In error404.php, have a function which will generate the HTML for the 404 error, and call this function when you want to display the 404 error.

Cheers,
Martin.

[deanx0r]

You reckon this would work?

<?php

if*($page=='about')*include('about.php');

if*($page=='photoalbum')*include('album.php');

if*($page=='links')*include('links.php');

if*($page=='about-brandon')*include('brandon.php');

else {

if*(file_exists($show)){

@include("$show");

}else{

@include("error404.php");

}
}

?>

[Darkness']

at the very bottom of your about page put a HALT command in there, so it halts all other PHP related commands after it.

Other than that, im not sure. kinda half asleep atm :P

[Bangers]

PHP Code:

<?php
if ($page=='about') 
    include('about.php');
else if ($page=='photoalbum') 
    include('album.php');
else if ($page=='links') 
    include('links.php');
else if ($page=='about-brandon') 
    include('brandon.php');
endif;
if (file_exists($show))
    include('$show');
else
    include('error404.php');
endif;
?>

an exit command goes after error404 but i forgot what it is
exit;
or like exit(1);

or something

I presume $show is already set to something?

[snoopie]

I don't know PHP either but the conditional logic in Bangers post and the original is not the same. That is if the if, else if and else statements have the same meaning as they do in Java, i'd be surprise if they didn't

Here is my guess

PHP Code:

<?php
if ($page=='about') 
    include('about.php');
endif
if ($page=='photoalbum') 
    include('album.php');
endif
if ($page=='links') 
    include('links.php');
endif
if ($page=='about-brandon') 
    include('brandon.php');
endif;
if (file_exists($show))
    include('$show');
else
    include('error404.php');
endif;
?>

[deanx0r]

Originally posted by Bangers

an exit command goes after error404 but i forgot what it is
exit;
or like exit(1);

or something

I presume $show is already set to something?

I find that just "exit;" works fine, I'm presuming that $show will just be used like "bs.php?show=somepage.php"...

[MWP]

Originally posted by dicey
Hola!

....

Somehow something is inlcuding the error404.php into any page that works!

I think its beacuse your doing:
if*(file_exists($show))

It wont find the file because its not named right... should be:
if*(file_exists("$show.php"))

?

But the if.. else or using a big switch/case statement would be the best way.

[Bangers]

Originally posted by snoopie
I don't know PHP either but the conditional logic in Bangers post and the original is not the same. That is if the if, else if and else statements have the same meaning as they do in Java, i'd be surprise if they didn't

Here is my guess

PHP Code:

<?php
if ($page=='about') 
    include('about.php');
endif
if ($page=='photoalbum') 
    include('album.php');
endif
if ($page=='links') 
    include('links.php');
endif
if ($page=='about-brandon') 
    include('brandon.php');
endif;
if (file_exists($show))
    include('$show');
else
    include('error404.php');
endif;
?>

naa thats not right because you cant end a if statement then continue it on.

I just released, hes got $page and $show to be 2 different variables when they basically do the same thing.

[deanx0r]

Actually, this would do the job.

PHP Code:

<?php
$page = $page . '.php';
if (file_exists($page)) {
  include($page);
}
else {
  include('error404.php');
}
?>

This does work, I just tried it out. So if he wants to include the about.php file, then the URL is just bs.php?page=about

[dicey]

What I am trying to say is that I want the working pages NOT to inlcude the error404.php into any of the pages.

I want something like if a page exists. Do NOT include the error404.php

If a page that does NOT exist. I want the error404.php to come up in action to let the surfers know that there is a 404.

Please let me know.

Thank you

[deanx0r]

Yeah dicey that's what the code I used above does, ie.

This link is to an about page I quickly made that does exist:
http://members.lycos.co.uk/deanx0r/test.php?page=about
The about information shown is stored in 'about.php'....

Whereas if you were to go to something that doesn't exist like:
http://members.lycos.co.uk/deanx0r/t...ge=dflkgdfglkg
you'll be presented with my lame 404 page....

[Chazza]

Took me all of about 30 secs to spot the problem. You havent defined $show. If you still havent figured it out, let me know.

[dicey]

Lame question....

Where do I put that in? Do I need to modify it so I can add more links to it?

[Bangers]

Originally posted by Chazza
Took me all of about 30 secs to spot the problem. You havent defined $show. If you still havent figured it out, let me know.

i saw that too, but i figured he had initialized it earlier.